SOLR-14558: Record all log lines in SolrLogPostTool #1570
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, SolrLogPostTool ignored all log-lines that didn't fall into a narrow handful of known "types". This change adds a new "other" type, to hold all previously-ignored log records. This allows all log records to be searched - not just the whitelisted cluster-traffic event types.(queries, commits, etc.)
Solution
Straightforward implementation.
Tests
New test to SolrLogPostToolTest. Manual testing.
Checklist
Please review the following and check all that apply:
master
branch.ant precommit
and the appropriate test suite.