Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-14570: Edismax round plugin #1578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SOLR-14570: Edismax round plugin #1578

wants to merge 1 commit into from

Conversation

MighTguY
Copy link

@MighTguY MighTguY commented Jun 15, 2020

Description

To make the rounding of the Match mode in Edismax, i.e if the mm.roundOff is true, it will round off the Edismax Match mode queries

Solution

In this, we have enabled a flag, when this flag is true It will round off the minimum classes required instead of always selecting the floor value.

Tests

Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.

I have run the test cases for the SolrPluginUtils.calculateMinShouldMatch tests are included in the testMinShouldMatchCalculatorWithRoundoff method

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ant precommit and the appropriate test suite.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant