LUCENE-9405: Ensure IndexWriter only closes merge readers once. #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted ie. would produce a fully deleted segment.
mikemccand
approved these changes
Jun 15, 2020
lucene/CHANGES.txt
Outdated
| @@ -266,6 +266,9 @@ Bug Fixes | |||
| * LUCENE-9362: Fix equality check in ExpressionValueSource#rewrite. This fixes rewriting of inner value sources. | |||
| (Dmitry Emets) | |||
|
|
|||
| * LUCENE-9405: IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted. | |||
| (Simon Willnauer, Mike Mccandless, Mike Sokolov) | |||
There was a problem hiding this comment.
Maybe also add @msfroh (Michael Froh)? -- I think he fixed this originally in the first PR.
There was a problem hiding this comment.
yeah, and you can remove me - I am just a conduit!
There was a problem hiding this comment.
I added him, thanks for pointing this out.
There was a problem hiding this comment.
I will keep you anyways @msokolov
msokolov
reviewed
Jun 15, 2020
| @@ -4167,4 +4167,38 @@ public void testSegmentCommitInfoId() throws IOException { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public void testMergeZeroDocsMergeIsClosedOnce() throws IOException { | |||
msokolov
approved these changes
Jun 15, 2020
s1monw
added a commit
that referenced
this pull request
Jun 15, 2020
IndexWriter incorrectly calls closeMergeReaders twice when the merged segment is 100% deleted ie. would produce a fully deleted segment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IndexWriter incorrectly calls closeMergeReaders twice when the
merged segment is 100% deleted ie. would produce a fully deleted
segment.