LUCENE-9427: Ensure unified highlighter considers all terms in fuzzy query. #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… query. This fixes a regression where if a fuzzy query corresponds to an exact match (for example it has maxEdits: 0), then the unified highlighter doesn't produce highlights for the matching terms. The proposed fix is to always pass back an automaton when visiting a fuzzy query. This seems to match the previous behavior before the regression was introduced.
|
It looks like this behavior changed during the |
jtibshirani
changed the title
|
Related: https://issues.apache.org/jira/browse/LUCENE-9274 I think ideally the fix would be https://issues.apache.org/jira/browse/LUCENE-9277, but this works as a stopgap. |
|
Thanks @romseygeek for taking a look. What do you see as the next steps? Would it make sense to merge this, and I could look into LUCENE-9277 in a follow-up? |
madrob
approved these changes
Jul 31, 2020
romseygeek
approved these changes
Aug 3, 2020
There was a problem hiding this comment.
LGTM, thanks @jtibshirani . Can you add a CHANGES.txt entry, and then I'll merge it in.
|
I just pushed a changelog update. |
|
Merged to master in 688583f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression where if a fuzzy query corresponds to an exact match
(for example it has maxEdits: 0), then the unified highlighter doesn't produce
highlights for the matching terms.
The proposed fix is to always pass back an automaton when visiting a fuzzy
query. This seems to match the previous behavior before the regression was
introduced.