LUCENE-9446: In boolean rewrite, remove MatchAllDocsQuery filter clauses #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only removed 'match all' FILTER clauses if there was at least one MUST clause. Now they're also removed if there is another distinct FILTER clause. This lets boolean queries like `#field:value #*:*` be written to `#field:value`.
jpountz
reviewed
Aug 3, 2020
| .build(); | ||
| expected = new BoostQuery(new ConstantScoreQuery( | ||
| new TermQuery(new Term("foo", "bar"))), 0.0f); | ||
| assertEquals(expected, searcher.rewrite(bq)); |
There was a problem hiding this comment.
maybe also add a test for the case when there are two MatchAllDocsQuery queries as filters with no MUST clauses?
|
Thanks for the review, I added another test and a changelog entry. |
jpountz
approved these changes
Aug 4, 2020
jpountz
pushed a commit
that referenced
this pull request
Aug 4, 2020
…ses (#1709) Previously, we only removed 'match all' FILTER clauses if there was at least one MUST clause. Now they're also removed if there is another distinct FILTER clause. This lets boolean queries like `#field:value #*:*` be written to `#field:value`.
|
FYI I backported to 8.7 and moved the CHANGES entry from 9.0 to 8.7. |
gus-asf
pushed a commit
to gus-asf/lucene-solr
that referenced
this pull request
Sep 4, 2020
…ses (apache#1709) Previously, we only removed 'match all' FILTER clauses if there was at least one MUST clause. Now they're also removed if there is another distinct FILTER clause. This lets boolean queries like `#field:value #*:*` be written to `#field:value`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only removed 'match all' FILTER clauses if there was at least one
MUST clause. Now they're also removed if there is another distinct FILTER clause.
This lets boolean queries like
#field:value #*:*be written to#field:value.