LUCENE-9497: add google error prone checks #1828
Conversation
…all the warnings, otherwise it stops on the first one.
…oesn't complain about missing types.
…ison. error_prone uses built-in SuppressWarnings (which is kind of neat).
| } | ||
|
|
||
| tasks.withType(JavaCompile) { task -> | ||
| options.errorprone.errorproneArgs = [ |
There was a problem hiding this comment.
I would also like to see options.errorprone.disableWarningsInGeneratedCode = true
There was a problem hiding this comment.
I suggested the same to Varun.
There was a problem hiding this comment.
Let's add this ? I probably missed it in my PR
| tasks.withType(JavaCompile) { task -> | ||
| options.errorprone.errorproneArgs = [ | ||
| // test | ||
| '-Xep:ExtendingJUnitAssert:OFF', |
There was a problem hiding this comment.
Personal style, but I think options.errorprone { disable 'ExtendingJUnitAssert' }
is more clear than using -Xep?
There was a problem hiding this comment.
I am okay with either of the two styles. Ideally we'd want this list to get much shorter soon :)
There was a problem hiding this comment.
Varun - feel free to take this branch (or patch) and roll it out on yours. I didn't intend it to be committed, I just wanted to show what's needed for it to compile and work.
There was a problem hiding this comment.
sounds good! I'll take the current branch and add two things and then commit the code
options.errorprone.disableWarningsInGeneratedCode = true- CHANGES entry
| @@ -523,6 +523,7 @@ public void clear() { | |||
| * @throws NullPointerException | |||
| * if the given map is <code>null</code>. | |||
| */ | |||
| @SuppressWarnings("ReferenceEquality") | |||
There was a problem hiding this comment.
This was the example you wanted to try out on how to suppress legitimate warnings of ReferenceEquality ( or any other warnings ) when we start enabling the checks ?
There was a problem hiding this comment.
Yes, exactly. I wanted the pr to include an example of how this can be done.
No description provided.