LUCENE-8626: Standardize Lucene Test Files #2026
Conversation
|
LGTM. We can check these in piecemeal rather than do them all at once, as you say the PRs get massive... |
|
Wouldn't it be better to add test convention enforcement first, followed by gradual rename of all convention-excluded files? I filed a suggestion on how this could be done - it doesn't have to be that particular one; can be anything but would be better than nothing? |
|
@dweiss I'm of the opinion that they could happen in parallel because we know in which direction we are going given the current state. The enforcement will obviously be a plus, but both the enforcement and the renaming are both in flight and gradually landing. |
|
ok. |
| import org.locationtech.spatial4j.context.SpatialContext; | ||
| import org.locationtech.spatial4j.shape.Shape; | ||
|
|
||
| public class TestQueryEqualsHashCode extends LuceneTestCase { |
There was a problem hiding this comment.
Did you intend to add this as a duplicate file?
There was a problem hiding this comment.
what is the duplicate?
There was a problem hiding this comment.
I intended to remove the previous file lucene/spatial-extras/src/test/org/apache/lucene/spatial/QueryEqualsHashCodeTest.java
There was a problem hiding this comment.
I see, I didn't remove the original in that case good catch
|
Thank you @MarcusSorealheis and everyone |
Description
Janitor here, moving a closer to a standard test file naming convention, starting with Lucene.
Solution
Janitorial work based on the work that @cpoerschke started a couple years ago in the ticket from the title.Almost every change was identical. More to come. PR was already growing too big.
Tests
These are all tests.
Checklist
Please review the following and check all that apply:
masterbranch../gradlew check.