LUCENE-9594 Add linear function for FeatureField #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a linear function and newLinearQuery for FeatureField
jpountz
reviewed
Nov 10, 2020
| * <ul> | ||
| * <li>{@link #newLinearQuery w * S}. This is the simplest function | ||
| * where no transformation is applied on the feature value, and | ||
| * the feature value itself multiplied by weight defines the score. |
There was a problem hiding this comment.
"the simplest" might suggest that this would be a good one to start with, when in fact I think this is the most expert function in my opinion given that it expects the feature to already be encoded in the index in a way that makes sense for scoring. Maybe javadocs should better convey that this is expert functionality?
jpountz
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a linear function and newLinearQuery for FeatureField