LUCENE-9536: Correct the OrdinalMap optimization. #2070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only checked that the first segment's ordinal deltas were all zero. This didn't account for some rare cases where the segment's ordinals matched the global ones, but it did not contain all terms. This can happen when using a FilteredTermsEnum, for example when merging a segment with deletions.
|
This should fix the failures we're seeing like |
jpountz
approved these changes
Nov 10, 2020
jpountz
pushed a commit
that referenced
this pull request
Nov 10, 2020
Previously we only checked that the first segment's ordinal deltas were all zero. This didn't account for some rare cases where the segment's ordinals matched the global ones, but it did not contain all terms. This can happen when using a FilteredTermsEnum, for example when merging a segment with deletions.
msfroh
pushed a commit
to msfroh/lucene-solr
that referenced
this pull request
Nov 18, 2020
Previously we only checked that the first segment's ordinal deltas were all zero. This didn't account for some rare cases where the segment's ordinals matched the global ones, but it did not contain all terms. This can happen when using a FilteredTermsEnum, for example when merging a segment with deletions.
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
Previously we only checked that the first segment's ordinal deltas were all zero. This didn't account for some rare cases where the segment's ordinals matched the global ones, but it did not contain all terms. This can happen when using a FilteredTermsEnum, for example when merging a segment with deletions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only checked that the first segment's ordinal deltas were all
zero. This didn't account for some rare cases where some of the segment's
ordinals are filtered out, so the ordinals aren't contiguous. In these cases we
fill in dummy values for the missing ordinal deltas. So a segment's ordinals
can appear to match the global ordinals perfectly, but not actually contain all
the terms.
Such a case can arise when using a FilteredTermsEnum, for example when merging
a segment with deletions.