LUCENE-9592: Loosen equality checks in TestVectorUtil. #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msokolov
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
Thanks! Yes, I think your analysis is good - we see people experimenting with quantizing down to a byte-per-sample while maintaining good near-neighbor matching results. https://ai.googleblog.com/2020/07/announcing-scann-efficient-vector.html, for example, showed some promising results in this vein. Are you able to push the commit yet?
Not yet, I'm still waiting on account credentials. |
TestVectorUtil occasionally fails because of floating point errors. This change slightly increases the epsilon in equality checks -- testing shows that this will greatly decrease the chance of failure.
jtibshirani
force-pushed
the
test-vector-utils
branch
from
9f3c727
to
1315109
Compare
ctargett
pushed a commit
to ctargett/lucene-solr
that referenced
this pull request
Dec 3, 2020
TestVectorUtil occasionally fails because of floating point errors. This change slightly increases the epsilon in equality checks -- testing shows that this will greatly decrease the chance of failure.
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
TestVectorUtil occasionally fails because of floating point errors. This change slightly increases the epsilon in equality checks -- testing shows that this will greatly decrease the chance of failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestVectorUtil occasionally fails because of floating point errors. This
change slightly increases the epsilon in equality checks -- testing shows that
this will greatly decrease the chance of failure.