SOLR-14999: Option to set the advertised port for Solr. #2089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madrob
reviewed
Nov 18, 2020
HoustonPutman
added a commit
that referenced
this pull request
Jan 9, 2021
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 11, 2021
ctargett
pushed a commit
to ctargett/lucene-solr
that referenced
this pull request
Jan 11, 2021
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Jan 15, 2021
ctargett
pushed a commit
that referenced
this pull request
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-14999
I am open to suggestions on the naming of this new option. Currently I have
-Dsolr.port.advertiseandSOLR_PORT_ADVERTISE, because I think those are more descriptive names thanhostPort.This is backwards compatible with the current
solr.xmls, because the default value (jetty.port) is now checked in the Java code, rather than the xml.