Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconcile upgrade notes in master #2103

Merged
merged 5 commits into from
Dec 2, 2020

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Nov 27, 2020

The upgrade notes in ref-guide tends to sometimes be updated in 8.x branches only and not synced to master branch.
This is an attempt, (inspired by and fixes #2102). I diffed the branch_8x version with master and saw that the 8x wording in most cases was more up to date. I tried to make sure that the updates are valid for 9.x, and skipped a few refguide links that I I believe may have been since removed, but have not tried to compile the refguide to detect its validity.

@janhoy janhoy requested a review from ctargett November 27, 2020 22:10
Signed-off-by: Jan Høydahl <janhoy@apache.org>
Signed-off-by: Jan Høydahl <janhoy@apache.org>
…er all :)

Signed-off-by: Jan Høydahl <janhoy@apache.org>
Copy link
Contributor

@ctargett ctargett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. In a couple cases I think the branch_8x wording is strange when it's on master, but the entire contents of the page will be moved and re-edited when we actually release 9.0 so making sure the general ideas are there is fine.

@janhoy janhoy merged commit e3572d0 into apache:master Dec 2, 2020
@janhoy janhoy deleted the reconcile-upgrade-notes branch December 2, 2020 22:28
ctargett pushed a commit to ctargett/lucene-solr that referenced this pull request Dec 16, 2020
epugh pushed a commit to epugh/lucene-solr-1 that referenced this pull request Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants