Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-15017: The core's lib/ folder content is not loaded in the classloader anymore when the core's configuration does not define any <lib> element #2107

Merged
merged 4 commits into from Dec 1, 2020
Merged

SOLR-15017: The core's lib/ folder content is not loaded in the classloader anymore when the core's configuration does not define any <lib> element #2107

merged 4 commits into from Dec 1, 2020

Conversation

tmortagne
Copy link
Member

@tmortagne
SOLR-15017: The core's lib/ folder content is not loaded in the class…
39aef95 
…loader anymore when the core's configuration does not define any <lib> element
@dsmiley
Copy link
Contributor

dsmiley commented Nov 30, 2020

+1 LGTM. I assume you will test this manually? (good enough). LMK when done; I'll merge this.

@tmortagne
Copy link
Member Author

I was wondering where would be the best place to add unit tests actually, I could not find a SolrConfigTest but maybe you have a idea of a place dedicated to SolrConfig validation already.

@dsmiley
Copy link
Contributor

dsmiley commented Nov 30, 2020

See org.apache.solr.core.TestCoreContainer#testSharedLib which looks interesting. You might do something similar and add to TestConfig, and ignore the built-in core in TestConfig since that one probably is using . You could use solr/configsets/minimal.conf

@tmortagne
SOLR-15017: The core's lib/ folder content is not loaded in the class…
d9ff957 
…loader anymore when the core's configuration does not define any <lib> element

* add unit test
@tmortagne
Copy link
Member Author

Unit test added following TestConfig#testLib() but with a different config.

@dsmiley
Copy link
Contributor

dsmiley commented Dec 1, 2020

Excellent. Please add to solr/CHANGES.txt in the 8.8 bug fix section at the end, the following:

* SOLR-15017: Core lib directories were not being recognized unless the solrconfig included a <lib> directive.
  (Thomas Mortagne)

Meaningwhile I'm running all tests...

@tmortagne
SOLR-15017: The core's lib/ folder content is not loaded in the class…
2d12e1e 
…loader anymore when the core's configuration does not define any <lib> element

* update the changelog
@tmortagne
Merge branch 'master' into SOLR-15017
4232ffb
@tmortagne
Copy link
Member Author

Fix the conflict with solr/CHANGES.txt.

@dsmiley dsmiley merged commit feb897a into apache:master Dec 1, 2020
dsmiley pushed a commit that referenced this pull request Dec 1, 2020
@tmortagne @dsmiley
SOLR-15017: Core's lib/ dir was ignored sometimes (#2107)
ce1b907 
A core's lib/ folder was ignored when the core's configuration did not define any <lib> element.  This is a regression introduced in 8.6 by SOLR-14197.

(cherry picked from commit feb897a)
ctargett pushed a commit to ctargett/lucene-solr that referenced this pull request Dec 16, 2020
@tmortagne @ctargett
SOLR-15017: Core's lib/ dir was ignored sometimes (apache#2107)
d328751 
A core's lib/ folder was ignored when the core's configuration did not define any <lib> element.  This is a regression introduced in 8.6 by SOLR-14197.
epugh pushed a commit to epugh/lucene-solr-1 that referenced this pull request Jan 15, 2021
@tmortagne
SOLR-15017: Core's lib/ dir was ignored sometimes (apache#2107)
c5ce475 
A core's lib/ folder was ignored when the core's configuration did not define any <lib> element.  This is a regression introduced in 8.6 by SOLR-14197.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tmortagne @dsmiley