Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-15046: Check if SOLR_SSL_ENABLED strictly equal to true for setting solr.jetty.https.port #2145

Merged
merged 2 commits into from Dec 14, 2020

Conversation

thelabdude
Copy link
Contributor

@thelabdude thelabdude commented Dec 14, 2020

Description

See JIRA: https://issues.apache.org/jira/browse/SOLR-15046

Solution

Fix bin/solr IF statement.

Tests

Manual test using:

cd solr
ant server
bin/solr start -c

bin/solr create -c test -s 1 -d _default
WARNING: Using _default configset with data driven schema functionality. NOT RECOMMENDED for production use.
         To turn off: bin/solr config -c test -p 8983 -action set-user-property -property update.autoCreateFields -value false
Created collection 'test' with 1 shard(s), 1 replica(s) with config-set 'test'

Checklist

Please review the following and check all that apply:

  • I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • I have created a Jira issue and added the issue ID to my pull request title.
  • I have given Solr maintainers access to contribute to my PR branch. (optional but recommended)
  • I have developed this patch against the master branch.
  • I have run ./gradlew check.
  • I have added tests for my changes.
  • I have added documentation for the Ref Guide (for Solr changes only).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant