BlobDirectoryFactory correctly deletes directories in the blob store #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and reuses BlobStore and BlobPusher.
dsmiley
approved these changes
Jan 15, 2021
There was a problem hiding this comment.
LGTM. I'm not super familiar with some of this but I found it interesting to explore some of the methods on DirectoryFactory like cleanupOldIndexDirectories to see when they are called.
I wouldn't add to the BlobStore abstraction unless it's totally equivalent to BackupRepository which I strongly think we're going to migrate to.
|
@bruno-roustant / @dsmiley is this still valid? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and reuses BlobStore and BlobPusher.