LUCENE-9750: Hunspell: improve suggestions for mixed-case misspelled words #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug report, maybe? |
dweiss
approved these changes
Feb 10, 2021
| @@ -70,7 +70,7 @@ | |||
|
|
|||
| /** In-memory structure for the dictionary (.dic) and affix (.aff) data of a hunspell dictionary. */ | |||
| public class Dictionary { | |||
| // Derived from woorm/ openoffice dictionaries. | |||
| // Derived from woorm/LibreOffice dictionaries. | |||
| return spell(title) ? title : candidate; | ||
| if (Character.isUpperCase(original.charAt(0))) { | ||
| String title = Character.toUpperCase(candidate.charAt(0)) + candidate.substring(1); | ||
| if (title.contains(" ") || spell(title)) { |
There was a problem hiding this comment.
Just out of curiosity - Hunspell doesn't take into account odd whitespace symbols (like non-breakable space), does it? I've spent a number of hours of my life debugging things that should work looking at the input only to turn out white spaces were not actually " "...
There was a problem hiding this comment.
In this place, the plain normal space is hardcoded
Most likely, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a failing Hunspell repo test
Solution
Replicate Hunspell's logic around suggestion casing, especially mixed-case ones
Tests
i58202from Hunspell repo, whatever that meansChecklist
Please review the following and check all that apply:
masterbranch../gradlew check.