Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-9773: upgrade icu to 68.2 #2372

Merged
merged 1 commit into from
Feb 15, 2021
Merged

LUCENE-9773: upgrade icu to 68.2 #2372

merged 1 commit into from
Feb 15, 2021

Conversation

rmuir
Copy link
Member

@rmuir rmuir commented Feb 15, 2021

Upgrade from icu 62.2 to 68.2, with Unicode 13 support.

Modify GenerateUTR30DataFiles to take the release tag as a program argument. Gradle populates this automatically, removing a manual step from regeneration process.

@dweiss made a minor tweak to regeneration: previously one of the java tools had a version number in java constant, I changed it to take this tag name as parameter, set by gradle instead.

Upgrade from icu 62.2 to 68.2, with Unicode 13 support.

Modify GenerateUTR30DataFiles to take the release tag as a program
argument. Gradle populates this automatically, removing a manual step
from regeneration process.
@rmuir rmuir requested a review from dweiss February 15, 2021 15:39
Copy link
Contributor

@dweiss dweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also checked and generation works on Windows with this new version, yay.

image

@rmuir rmuir merged commit dd91f5c into apache:master Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants