SOLR-15101: Add list/delete APIs for incremental backups #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOLR-13608 introduces a new "incremental" backup format, which allows storage of multiple backup "points" in the same location. This development introduces a need for APIs to manage these potentially plural backups. This commit introduces /admin/collections?action=LISTBACKUPS and /admin/collections?action=DELETEBACKUP to handle these backups.
gerlowskija
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SOLR-13608 introduced a new "incremental" backup format, which allows
storage of multiple backup "points" in the same location. But with this new
capability comes the need to be able to list and individually delete these
backups.
Solution
This commit introduces /admin/collections?action=LISTBACKUPS and
/admin/collections?action=DELETEBACKUP to handle these backups.
It's actually a backport of an existing PR for master.
Tests
See the changes to AbstractIncrementalBackupTest and TestCollectionAdminRequest.
Checklist
Please review the following and check all that apply:
ant precommit test.