Make FacetField.TYPE public #239
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Everything else in the class is public, and all the other Field.TYPE constants are public. I want to use this in a field factory class.
|
Thanks @msokolov, that makes sense ... I'll merge. |
|
OK |
I tried to run ant precommit in a local lucene checkout to verify this would be OK, but I get this failure I don't understand: "ivy:cachepath doesn't support the nested 'dependency' element" Would you be able to check again? Thanks
|
OK, I added the javadoc. Not sure if that commit generates e-mails on its own, so here's another message just in case. |
|
Thanks @msokolov; I'll look. On that cryptic error you saw, that might mean your ivy version is too old: see http://lucene.472066.n3.nabble.com/BUILD-FAILED-solr-6-5-0-td4330787.html |
|
OK I pushed this for 7.1 and 8.0. Can you close this PR now? Thanks. |
|
Thanks, Mike |
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everything else in the class is public, and all the other Field.TYPE constants are public. I want to use this in a field factory class.