LUCENE-10070: Skip deleted documents during facet counting for all documents #2577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goankur could you please take a quick look and make sure this backport looks good to you? Everything was very trivial except for |
|
FYI, will hold on this backport until 8.10 releases and an 8.11 section is added to CHANGES as part of that process (this will go in 8.11) |
|
@gsmiller I did take a look at |
…ants to skip low-scoring hits but the combined score mode doesn't allow it.
…sponse from server (apache#2580)
…in NormValuesWriter
…and currentValues in SortedSetDocValuesWriter
We should not set single sort when the search_after is non-null; otherwise, we will incorrectly skip documents whose values are equal to the value from the search_after and docIDs are greater than the docID from the search_after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport from
main