SOLR-11617 #310
Closed
SOLR-11617 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice docs. Lets not provide an option to configure whitespace/trim handling -- configuration-itis. IMO we should be consistent with other parts of Solr on what to do (e.g. props on core creation) but you seem to feel strongly about it so whatever. It's not that I don't disagree with your point of view, it's only that I think consistency is a higher virtue. Can you add a test please? It could be a simple modification to an existing test. |
dsmiley
approved these changes
Jan 28, 2018
| public static class ModifyAlias extends AsyncCollectionAdminRequest { | ||
|
|
||
| private final String aliasName; | ||
| private static Map<String,String> metadata = new HashMap<>(); |
There was a problem hiding this comment.
Obviously "static" is a mistake here; I'll fix it.
| public SolrParams getParams() { | ||
| ModifiableSolrParams params = (ModifiableSolrParams) super.getParams(); | ||
| params.set(CoreAdminParams.NAME, aliasName); | ||
| metadata.keySet().forEach(key -> params.set("metadata." + key, metadata.get(key))); |
There was a problem hiding this comment.
Better:
metadata.forEach((key, value) -> params.set("metadata." + key, value));
I'll do it.
|
https://issues.apache.org/jira/browse/SOLR-11617 was released in Solr 7.3, so this PR can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes as mentioned in Jira comment, plus rather than decide I provided an option for the user to enable whitespace values. By default this is off and whitespace values are treated as null, but if the user really wants to set a value to 3 spaces they can by passing allowWhitespaceValues=true. I'm fairly set against pure whitespace keys unless someone can supply up with a good reason for that.