SOLR-9303: Refactor CloudSolrClient for extensibility #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CloudSolrClient.sendRequest() is currently written as one big chunk of code, making it difficult to customize it on a subclass.
mnilsson23
pushed a commit
to mnilsson23/lucene-solr
that referenced
this pull request
Aug 26, 2016
|
Nobody cares, closing it |
markrmiller
added a commit
that referenced
this pull request
Jul 10, 2020
tflobbe
added a commit
that referenced
this pull request
Apr 20, 2021
epugh
pushed a commit
to epugh/lucene-solr-1
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using a custom Solr plugins which adds extra constraints on which nodes I can access.
To respect these constraints, I needed to use a customized version of CloudSolrClient.
Unfortunately, CloudSolrClient.sendRequest() is currently written as one big chunk of code, breaking OO's SOLID principle and making it is impossible for me to customize it on a subclass.
I have refactored this method in 3 steps: