LUCENE-8585: Index-time jump-tables for DocValues #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… lucene70 codec classes (temporary kludge until the correct strategy is found)
jpountz
reviewed
Dec 14, 2018
lucene/core/src/java/org/apache/lucene/codecs/lucene70/package-info.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
Outdated
Show resolved
Hide resolved
…arger changes underway)
…edDISI creation) and introduced secondary slices for jump-tables to avoid cache thrashing. The DENSE block rank structure handling is still in flux: Current implementations uses an explicit slice, but this might change depending on review discussion.
…es a slice. BaseDocValuesFormatTestCase.testSparseGCDCompression does not pass yet
… unit tests passes
tokee
commented
Dec 19, 2018
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
Outdated
Show resolved
Hide resolved
…IndexedDISI was not positioned at 0
jpountz
reviewed
Dec 21, 2018
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
lucene/core/src/java/org/apache/lucene/codecs/lucene80/Lucene80DocValuesProducer.java
Outdated
Show resolved
Hide resolved
lucene/core/src/test/org/apache/lucene/index/TestDocValues.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
Outdated
Show resolved
Hide resolved
lucene/test-framework/src/java/org/apache/lucene/index/BaseDocValuesFormatTestCase.java
Outdated
Show resolved
Hide resolved
|
I forgot to mention: precommit complains about unused imports. |
…ank-spans for DENSE blocks
…along with the slice (not very elegant)
…to provide jump-table support to empty end-blocks
jpountz
reviewed
Jan 4, 2019
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
…nd not jump-tables. TestIndexedDISI.testFewMissingDocs fails
jpountz
approved these changes
Jan 11, 2019
lucene/core/src/java/org/apache/lucene/codecs/lucene80/IndexedDISI.java
Outdated
Show resolved
Hide resolved
…Powers and added unit-test for it
…on) caused a NullPointerException
…se to TestLucene80DocValuesFormat
…ble was still present even though the jump-table input was changed to start at the jump-table
…andomAccessInput reuse
jpountz
approved these changes
Jan 17, 2019
|
|
||
| // Returns the offset to the jump-table for vBPV | ||
| private long writeValuesMultipleBlocks(SortedNumericDocValues values, long gcd) throws IOException { | ||
| long[] offsets = new long[ArrayUtil.oversize(100, Long.BYTES)]; // 100 blocks = 1.6M values |
There was a problem hiding this comment.
can you reduce the initial size so that testing exercises this line of code?
| @@ -1216,7 +1219,7 @@ private void doTestNumericsVsStoredFields(double density, LongSupplier longs) th | |||
| doc.add(dvField); | |||
|
|
|||
| // index some docs | |||
| int numDocs = atLeast(300); | |||
| int numDocs = atLeast((int) (minDocs*1.172)); | |||
There was a problem hiding this comment.
Yeah, that should have been explained. It is because I made the minDocs variable. Originally the test was fixed with 256 as minDocs. 256*1.172=300, so with this trick the numDocs/minDocs-factor stayed constant for the old tests. I have probably been overthinking this. Should I set it to something less puzzling like 1.5 or 2?
|
Closing pull request as this has been committed to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First complete attempt of LUCENE-8585, with all jump-tables at index-time and with the not-used-anymore lucene70 codec classes moved to backward-codecs.