LUCENE-8639: Prevent new threadstates from being created while we cut over to a new delete queue #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM -- sneaky. |
s1monw
force-pushed
the
fix_seq_no_accounting
branch
from
7382c78
to
a4381ab
Compare
|
I like the test case!! |
s1monw
force-pushed
the
fix_seq_no_accounting
branch
2 times, most recently
from
da1531d
to
43603e7
Compare
… over to a new delete queue This prevents an edge case where suddenly a lot of threads start indexing while we carry over sequence ids from the previous to the new delete queue. We now lock creation of new thread states for a very short time until we created and assigned a new delete queue.
s1monw
force-pushed
the
fix_seq_no_accounting
branch
from
43603e7
to
c538fa5
Compare
s1monw
added a commit
that referenced
this pull request
Jan 16, 2019
… over to a new delete queue (#535) This prevents an edge case where suddenly a lot of threads start indexing while we carry over sequence ids from the previous to the new delete queue. We now lock creation of new thread states for a very short time until we created and assigned a new delete queue.
s1monw
added a commit
that referenced
this pull request
Jan 16, 2019
… over to a new delete queue (#535) This prevents an edge case where suddenly a lot of threads start indexing while we carry over sequence ids from the previous to the new delete queue. We now lock creation of new thread states for a very short time until we created and assigned a new delete queue.
msokolov
pushed a commit
to msokolov/lucene-solr
that referenced
this pull request
Feb 4, 2019
… over to a new delete queue (apache#535) This prevents an edge case where suddenly a lot of threads start indexing while we carry over sequence ids from the previous to the new delete queue. We now lock creation of new thread states for a very short time until we created and assigned a new delete queue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an edge case where suddenly a lot of threads start indexing
while we carry over sequence ids from the previous to the new delete queue.
We now lock creation of new thread states for a very short time until we created and assigned
a new delete queue.