LUCENE-8833: Allow MMapDirectory subclasses to pre-load per IndexInput #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's useful to select if we preload a mmap on a per index input / file basis. Subclasses should be able to extend MMapDirectory to make it configurable.
mikemccand
approved these changes
Jul 2, 2019
| c.size(), chunkSizePower, new ByteBufferGuard(resourceDescription, useUnmap ? CLEANER : null)); | ||
| } | ||
| } | ||
|
|
||
| /** Maps a file into a set of buffers */ | ||
| final ByteBuffer[] map(String resourceDescription, FileChannel fc, long offset, long length) throws IOException { | ||
| final ByteBuffer[] map(String resourceDescription, FileChannel fc, long offset, long length, boolean preload) throws IOException { |
There was a problem hiding this comment.
It's somewhat confusing that the preload parameter shadows the instance variable; maybe rename the instance variable to globalPreload or preloadDefault or so to prevent future confusion?
|
superseded by #758 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's useful to select if we preload a mmap on a per index input / file
basis. Subclasses should be able to extend MMapDirectory to make it
configurable.