LUCENE-8867: Store point with cardinality for low cardinality leaves #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We discussed this today - thanks for the change! I'm not familiar with this area of the code, and not really qualified to assess it, but I did notice there are no tests with the patch. I guess we are supporting existing functionality, but are we sure that the existing tests are covering the different cardinalities? |
|
@msokolov I check that the new code is being hit in the tests so yes, it is covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new strategy for storing leaves with low cardinality and a new method to the IntersectsVisitor that can accept an array of docs. This can speed up searches when there are many equal points.