Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-8895: switch all FST usage to enable array-with-gaps encoding #753

Closed
wants to merge 2 commits into from

Conversation

msokolov
Copy link
Contributor

I'm not sure we want to commit this as-is, mainly because of the change to {{blocktreeords}} codec. With this change, if we encoded some node's outgoing Arcs as an array-with-gaps, we treat it as a list, scanning forward with a linear scan, rather than a binary search. Implementing binary search in this case might be possible, but it's quite complex. Another possibility is to leave the option of disabling the array-with-gaps opto and leaving it off for this one case. I'd like to get a sense how widely used this codec is and whether it's worth having that preserved in the API.

@msokolov
Copy link
Contributor Author

msokolov commented Jul 1, 2019

Based on feedback so far, this looks like a reasonable step. Also note latest commit removes unused Util.getByOutput() and related tests.

By the way, in addition to test and precommit, I also ran ant test -Dtests.postingsformat=FST50 since that uncovered some issues previously.

I'll push in a couple of days if there are no further comments.

@msokolov
Copy link
Contributor Author

msokolov commented Jul 2, 2019

OK, I realized that Util.getByOutput is a public method, so removing it in a minor rev. would be kind of rude, even if it is part of an @experimental API, given that it is not really necessary to remove, just cleanup. Besides, it's @dsmiley's favorite (part of the) API! So instead I'll just @deprecate and we can remove later after some baking period, assuming no exciting use cases pop up. I'll squash commits and push now

@msokolov msokolov closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant