LUCENE-8895: switch all FST usage to enable array-with-gaps encoding #753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure we want to commit this as-is, mainly because of the change to {{blocktreeords}} codec. With this change, if we encoded some node's outgoing Arcs as an array-with-gaps, we treat it as a list, scanning forward with a linear scan, rather than a binary search. Implementing binary search in this case might be possible, but it's quite complex. Another possibility is to leave the option of disabling the array-with-gaps opto and leaving it off for this one case. I'd like to get a sense how widely used this codec is and whether it's worth having that preserved in the API.