SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any thoughts on this? Seems safe enough to merge? |
|
Gentle Ping |
|
Thanks @atris. Changes look good to me, however, I think there are a couple more cases that we could change:
|
|
@tflobbe Thanks, for some reason, my grep command missed those ones. Updated the PR with the same. |
tflobbe
reviewed
Aug 23, 2019
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Variable.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Variable.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/SolrRequest.java
Outdated
Show resolved
Hide resolved
solr/solrj/src/java/org/apache/solr/client/solrj/impl/DelegationTokenHttpSolrClient.java
Outdated
Show resolved
Hide resolved
|
@tflobbe Thanks. I was slightly unsure about whether these sections actually need an immutable copy of the original set (by their usage patterns), hence was being conservative by doing copyOf instead of of(). However, post your comment, I looked at the call sites of these methods and they look to be fine with an immutable reference, so changed the calls. |
|
Thanks @atris! squashed/merged |
|
Thanks @tflobbe ! |
MarcusSorealheis
added a commit
to MarcusSorealheis/lucene-solr
that referenced
this pull request
Aug 27, 2019
…cusSorealheis/lucene-solr into enhancement_blockUnkwon-default-true * 'enhancement_blockUnkwon-default-true' of github.com:MarcusSorealheis/lucene-solr: (37 commits) SOLR-13699 - maxChars no longer working on CopyField with javabin SOLR-13699 - maxChars no longer working on CopyField with Javabin SOLR-13655: Fix precommit SOLR-11601: Improve geodist error message when using with LLPSF. SOLR-13655: Added CHANGES entry SOLR-13655:Upgrade Collections.unModifiableSet to Set.of and Set.copyOf (apache#817) SOLR-13702: Fix precommit SOLR-13702: Some components register twice their metric names (apache#834) LUCENE-8952: Use a sort key instead of true distance in NearestNeighbor. (apache#832) SOLR-13707: API to expose the currently used package name, details for each plugin SOLR-13707: API to expose the currently used package name, details for each plugin (apache#841) Additional logging in test framework methods that 'waitFor' something to better trace order of operations when failures occur SOLR-13257: Support deterministic replica routing SOLR-13706: Config API output is broken for "highlight" component LUCENE-8755: Spatial-extras quad and packed-quad trees now index points a little faster, and also fix an edge case bug. Fixes apache#824 removed unnecessary comments SOLR-13650: AwaitsFix TestContainerReqHandler.testCacheFromGlobalLoader SOLR-13650:ref guide typo SOLR-13704: correct error codes for client errors in expand component SOLR-13650: ref guide ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.