LUCENE-8933: Use expectThrows instead of expected. #830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusSorealheis
added a commit
to MarcusSorealheis/lucene-solr
that referenced
this pull request
Aug 20, 2019
…cusSorealheis/lucene-solr into enhancement_blockUnkwon-default-true * 'enhancement_blockUnkwon-default-true' of github.com:MarcusSorealheis/lucene-solr: (51 commits) Harden AliasIntegrationTest.testClusterStateProviderAPI SOLR-13694: IndexSizeEstimator NullPointerException. adding <SpanPositionRange> into XML Query Parser SOLR-13693: Use strongly-typed setters for cache parameters. LUCENE-8933: Use 'expectThrows' instead of 'expected'. (apache#830) LUCENE-8933: Validate JapaneseTokenizer user dictionary entry (apache#809) SOLR-13240: make operation-not-null checks consistent in TestPolicy.testNodeLostMultipleReplica (Richard Goodman via Christine Poerschke) SOLR-13688: Run the bin/solr export command multithreaded SOLR-13464: fix javadoc typo that precommit somehow missed? SOLR-13464: Test work arounds SOLR-13399: Adding splitByPrefix param to IndexSizeTrigger; some splitByPrefix test and code cleanup SOLR-13647: Default solr.in.sh contains incorrect default value SOLR-13568: Precommit fail Java var until 9x. Fail var... SOLR-13573: Add SolrRangeQuery getters for bounds SOLR-13593: Allow to look up analyzer components by their SPI names in field type configuration. LUCENE-8948: Change 'name' argument in ICU factories to 'form'. SOLR-13680: use try-with-resource to close closeable resources SOLR-13682: command line option to export documents to a file SOLR-13682: precommit errors SOLR-13682: command line option to export documents to a file ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
LuceneTestCase#expectThrows()instead ofexpected.