SOLR-13760 - restore viability of date math in TRA start property #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upon the receipt of the first document to avoid problems with date math calculations required by DRA's
|
oops, hmm forgot to do changes.txt... will add in separate commit. |
asfgit
pushed a commit
that referenced
this pull request
Oct 11, 2019
by fixing the start date for time routed aliases upon the receipt of the first document to avoid problems with date math calculations required by DRA's (cherry picked from commit be813bd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Date math parsing for TRA start
Solution
Invoke the DateMathParser.parseMath method rather than using the parseRouteKey method.
Tests
Added a test that fails without the fix to ensure support for date math is not lost again.
Checklist
Please review the following and check all that apply:
masterbranch.ant precommitand the appropriate test suite.