Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal rejection #913

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Commits on Oct 1, 2019

  1. LUCENE-8995: TopSuggestDocsCollector#collect should be able to signal…

    … rejection
    
    Currently the suggestion collectors collect method has no way of signaling back
    to the caller whether the matched completion it received was indeed collected.
    While this is currenty always the case for the default TopSuggestDocsCollector,
    there are implementations that overwrite this with custom collection logic that
    also deduplicates based on e.g. docID and/or context. Currently if those
    completions are rejected, the calling TopNSearcher has no way of noting these
    rejections and might therefore terminate early, missing on completions that
    should be returned.
    Christoph Büscher committed Oct 1, 2019
    Copy the full SHA
    c0e2aad View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2019

  1. Add TopSuggestDocs flag indicating that the search is complete

    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    8739bb0 View commit details
    Browse the repository at this point in the history
  2. Move surface form deduplication logic

    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    d42a88c View commit details
    Browse the repository at this point in the history
  3. Make queue larger for collectors that can reject

    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    3ffef37 View commit details
    Browse the repository at this point in the history
  4. Add larger test with rejections

    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    3b4b816 View commit details
    Browse the repository at this point in the history
  5. Apply increased queue size heuristic only once for filters or collect…

    …or rejections
    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    78c40a2 View commit details
    Browse the repository at this point in the history
  6. Reduce test size to stay below max queue size

    Christoph Büscher committed Oct 2, 2019
    Copy the full SHA
    5632320 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2019

  1. Adressing review comments

    Christoph Büscher committed Oct 9, 2019
    Copy the full SHA
    bb1ece6 View commit details
    Browse the repository at this point in the history
  2. Add second ctor for bwc

    Christoph Büscher committed Oct 9, 2019
    Copy the full SHA
    e72ac79 View commit details
    Browse the repository at this point in the history
  3. Add ctor javadoc

    Christoph Büscher committed Oct 9, 2019
    Copy the full SHA
    e51f262 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Adressing review comments

    Christoph Büscher committed Oct 16, 2019
    Copy the full SHA
    81bc00c View commit details
    Browse the repository at this point in the history
  2. Extend test to case where isComplete() returns false

    Christoph Büscher committed Oct 16, 2019
    Copy the full SHA
    2f3a1b9 View commit details
    Browse the repository at this point in the history