LUCENE-10060: Ensure DrillSidewaysQuery instances never get cached

[gsmiller]

Description

We need to ensure DrillSidewaysQuery instances never get cached. The process of caching the results ignores deleted docs (null acceptDocs passed to the BulkScorer). This is an issue with DrillSidewaysScorer since it has the (intentional) side-effect of populating the "sideways" FacetsCollector instances, which means it will included deleted docs in the sideways counts.

Solution

DrillSidewaysQuery#isCacheable advertises as never cacheable by returning false. Note that I also removed the older hack in DrillSideways that's no longer needed with this solution.

Tests

Added a new test that repro's the caching bug with both a CollectorManager and Collector execution path. Confirmed the test now passes.

Checklist

Please review the following and check all that apply:

• I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
• I have created a Jira issue and added the issue ID to my pull request title.
• I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
• I have developed this patch against the main branch.
• I have run ./gradlew check.
• I have added tests for my changes.

[gsmiller]

I'll backport to 8x

[zacharymorn]

LGTM! I like that this is a simple and yet formal fix to turn off caching for DSQ, instead of a hack. I've run this through the nightly tests against my other branch with collectorManager changes and everything passed, so we should be all good. Thanks @gsmiller again for the quick fix!

[gsmiller]

Thanks @zacharymorn for the quick review and double-checking the fix against your PR!