LUCENE-10106: Sort optimization wrongly skip first docs #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
approved these changes
Sep 15, 2021
| dir.close(); | ||
| } | ||
|
|
||
| public void testRandomLong() throws IOException { |
mayya-sharipova
approved these changes
Sep 15, 2021
There was a problem hiding this comment.
@dnhatn Thanks so much for fixing this bug, really appreciate!
We also should fix this bug on https://github.com/apache/lucene-solr branch 8.x.
Also would be good to fix it on 8.10 if not so late.
|
@romseygeek @mayya-sharipova Thanks for review.
Sure, I will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first documents of subsequent segments are mistakenly skipped when sort optimization is enabled. We should initialize maxDocVisited in NumericComparator to -1 instead of 0.