LUCENE-10131: Add backcompat indices for 8.10 and add LUCENE_8_10_0 to Version #343
Conversation
| @@ -383,6 +383,7 @@ public void testCreateEmptyIndex() throws Exception { | |||
| "sorted.8.0.0", | |||
| "sorted.8.1.0", | |||
| "sorted.8.1.1", | |||
| "sorted.8.10.0", | |||
There was a problem hiding this comment.
I think you also need an addition above to oldNames
There was a problem hiding this comment.
yes, that's the problem @madrob , see my comment in the PR description!
...ne/backward-codecs/src/test/org/apache/lucene/backward_index/TestBackwardsCompatibility.java
Outdated
Show resolved
Hide resolved
| * | ||
| * @deprecated (8.11.0) Use latest | ||
| */ | ||
| @Deprecated public static final Version LUCENE_8_10_0 = new Version(8, 10, 0); |
There was a problem hiding this comment.
I think you need to add an 8_11_0 version. A long time ago, when this all worked properly (like 8.2, I went spelunking in history) we would add the next minor immediately after a release.
There was a problem hiding this comment.
In main branch this looks good, with LUCENE_8_10_0 being added only. In branch_8x there would be a LUCENE_8_11_0, but that is already OK
There was a problem hiding this comment.
It seems 8_11 is needed for main too, I don't know why after 8.9, it worked without an 8_10 but I'm already frustrated by this split repo and the release process being broken
There was a problem hiding this comment.
I added this JIRA to track improving the release manager so this doesn't happen again: https://issues.apache.org/jira/browse/LUCENE-10141
Manually fixing up some steps missed during the 8.10 release process.
I don't think this is correct because 8.10 is not listed in the
oldNamesarray inTestBackwardsCompatibility. Somebody who understands how thetestAllVersionsTestedmethod is supposed to work on main (see comment about TRUNK in the code) needs to review.