Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUCENE-10179 No longer check for release status on mirrors #384

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

janhoy
Copy link
Contributor

@janhoy janhoy commented Oct 15, 2021

@janhoy janhoy requested a review from madrob October 15, 2021 11:53
Copy link
Contributor

@madrob madrob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we still want to keep a check for maven central?

@janhoy
Copy link
Contributor Author

janhoy commented Oct 15, 2021

I think we still want to keep a check for maven central?

Ah, I forgot that was part of the script. Do you want to reinstate but simplify the script, or is it perhaps enough that the RM checks two URLs, i.e.
https://dlcdn.apache.org/lucene/java/{{ release_version }} and https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/{{ release_version }}/lucene-core-{{ release_version }}.pom.asc?

@madrob
Copy link
Contributor

madrob commented Oct 15, 2021

Could the release wizard check the paths exist rather than asking the release manager to do so? I don't think we need a script for that anymore, we could do it inline in the wizard, no?

@janhoy
Copy link
Contributor Author

janhoy commented Oct 15, 2021

Could the release wizard check the paths exist rather than asking the release manager to do so? I don't think we need a script for that anymore, we could do it inline in the wizard, no?

Committed a function that performes the check inline. The output will be

The task will attempt to fetch https://dlcdn.apache.org/lucene/java/8.9.0/lucene-8.9.0-src.tgz.asc
to validate ASF repo, and https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/8.9.0/lucene-core-8.9.0.pom.asc
to validate Maven repo.

If the check fails, please re-run the task, until it succeeds.
Found https://dlcdn.apache.org/lucene/java/8.9.0/lucene-8.9.0-src.tgz.asc
Found https://repo1.maven.org/maven2/org/apache/lucene/lucene-core/8.9.0/lucene-core-8.9.0.pom.asc

Q: Mark task 'Check that artifacts are available' as completed? (y/n): y

If it fails, it will print:

Retrying download of url https://dlcdn.apache.org/lucene/java/9.0.0/lucene-9.0.0-src.tgz.asc after exception: HTTP Error 404: Not Found
Could not fetch https://dlcdn.apache.org/lucene/java/9.0.0/lucene-9.0.0-src.tgz.asc (HTTP Error 404: Not Found)

@janhoy janhoy merged commit f38c401 into apache:main Oct 15, 2021
@janhoy janhoy deleted the lucene10179-cdn branch October 15, 2021 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants