New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LUCENE-10328: Module path for compiling and running tests is wrong #571
Merged
Merged
Changes from 33 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
e8435cc
Non-functional changes cleaning up code
dweiss aaae8a6
Cleanups and refactorings without functional changes.
dweiss 7d0b70b
Make sure configurations use jar artifacts instead of split class+res…
dweiss bd0e82b
Work in progress, to be reverted and flattened.
dweiss 7519283
Convert some more modules to use test framework on module path
dweiss 9fe2855
LUCENE-10337: workaround for xerces and split packages.
dweiss 7743921
LUCENE-10335: IOUtils.getDecodingReader(Class<?>, String) is broken w…
dweiss 95c5754
LUCENE-10338: Scan for tests only by convention file name pattern (Te…
dweiss b8d445f
Follow-up to test convention moved.
dweiss 0f8678b
Use modular deps in the replicator.
dweiss 7e0f1dc
Separate spatial-extras test features into a separate subproject. The…
dweiss 6d88a74
Force certain projects to compile/run test in classpath mode until ci…
dweiss 605ac4d
Separate spatial-extras test features into a separate subproject.
dweiss c00fb51
Separate spatial-extras test features into a separate subproject.
dweiss 5904448
Update locks.
dweiss dd0fba5
Tweak the output from source validation. Remove NOCOMMITs, they're re…
dweiss 42a7472
Revert "LUCENE-10335: IOUtils.getDecodingReader(Class<?>, String) is …
dweiss a1f5f14
Permit gradle versions with a matching base version (for debugging gr…
dweiss 8f0cbb2
Apply Uwe's patch for LUCENE-10335
dweiss 067c9f4
Merge remote-tracking branch 'origin/main' into LUCENE-10328
dweiss 9b16978
Tidy.
dweiss 0875392
LUCENE-10338: make TestPosition an internal class inside TrivialLooka…
dweiss d0abc12
Multiple-mode rendering of module-path and classpath.
dweiss d7ff7e1
Add oddball hacks for ECJ which otherwise fails with errors. Nekohtml…
dweiss 66977bc
Correct javadoc.
dweiss f561e4f
Remaining fixes to get check to pass
dweiss 3f6069e
Run projects with modular tests with proper modular path - combined c…
dweiss df58882
Correct jar separation between source sets, add a test validating mod…
dweiss cb420e2
Add a runtime modular path dependency check.
dweiss b6ae29b
Don't tweak the paths for intellij.
dweiss 152bb76
Removing the main sourceset module - works with gradle but confuses i…
dweiss d5a408e
Add an awkward exclusion to break circular dependency in spatial3d
dweiss f87acbf
Add some initial module-patching infrastructure that tries not to bre…
dweiss b3b3168
Merging changes from uschindler:jira/LUCENE-10335
dweiss 855694c
Revert "Merging changes from uschindler:jira/LUCENE-10335"
dweiss 4366944
Merging with main.
dweiss 3265a67
LUCENE-10344: force ecj to run in classpath mode for projects/sources…
dweiss e91d84c
Merge branch 'main' of https://gitbox.apache.org/repos/asf/lucene int…
uschindler c76d65e
Revert some changes that were better fixed in other PR
uschindler 66509ff
Merge branch 'main' into LUCENE-10328
uschindler d88f5cf
Edit comment.
dweiss 1aac2dc
Merge remote-tracking branch 'origin/main' into LUCENE-10328
dweiss c6363fc
Use test source set constant.
dweiss c175e21
Add decision tree on how to configure classpath/ modular mode.
dweiss 938e01b
Make morfologik.tests extend from (modular) lucene test-framework.
dweiss d689960
Make core.tests utilize the test framework in a normal, modular way.
dweiss 67ecf7f
Merge remote-tracking branch 'origin/main' into LUCENE-10328
dweiss d1f3732
Merge branch 'main' into LUCENE-10328
dweiss File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this
mavenProjects
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah it is inverse. All projects that will land in Maven central. Yeah thats a better check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
by the way theres also the better operator
project !in rootProject.ext.mavenProjects
I used is elsewhere already.