MAHOUT-1610 [TESTS] Update tests to pass in Java 8

[srowen]

Right now, several tests don't seem to pass when run with Java 8 (at least on Java 8). The failures are benign, and just due to tests looking for too-specific values or expecting things like a certain ordering of hashmaps.

The tests can easily be made to pass both Java 8 and Java 6/7 at the same time by either relaxing the tests in a principled way, or accepting either output of two equally valid ones as correct.

(There's also one curious compilation failure in Java 8, related to generics. It is fixable by changing to a more explicit declaration that should be equivalent. It should be entirely equivalent at compile time, and of course, at run time. I am not sure it's not just a javac bug, but, might as well work around when it's so easy.)

[srowen]

I may still have the commit bit for ASF git, but can't merge the pull request myself. (I also realize I'm not yet sure if there's another step? will asfbot merge back to ASF git if merged here?)

Anyone who can merge this is welcome to do so!

[dlyubimov]

may still have the commit bit for ASF git, but can't merge the pull request myself
Thanks, Sean.

Yes, you can merge. A bit exploded beyond what's needed IMO but still useful [1]. Also, it works best if master is first merged to the PR branch and conflicts, if any, resolved there, so when you --squash stuff to master, you don't have to worry about conflicts on top of everything else. Hope this helps.

[1] http://mahout.apache.org/developers/github.html

[srowen]

Ah right, should have RTFM. Thanks! When you say "beyond what's needed" were you commenting on the PR, or on the docs? Just checking whether you meant you wanted to discuss the change more.

[dlyubimov]

I meant the PR doc. Strictly in my opinion, since original versions stuff
has been added that was not strictly to the point and makes read longer and
therefore harder than it needs be.

On Thu, Aug 28, 2014 at 9:14 AM, Sean Owen notifications@github.com wrote:

Ah right, should have RTFM. Thanks! When you say "beyond what's needed"
were you commenting on the PR, or on the docs? Just checking whether you
meant you wanted to discuss the change more.

—
Reply to this email directly or view it on GitHub
#46 (comment).

[dlyubimov]

�[32m- dssvd - the naive-est - q=0�[0m 1 [Executor task launch worker-1] ERROR org.apache.spark.executor.Executor - Exception in task ID 52 java.io.FileNotFoundException: http://67.195.81.155:38091/broadcast_4 at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1457) at org.apache.spark.broadcast.HttpBroadcast$.read(HttpBroadcast.scala:196) at org.apache.spark.broadcast.HttpBroadcast.readObject(HttpBroadcast.scala:89) at sun.reflect.GeneratedMethodAccessor7.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

not sure what may be causing this.