Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARCHTYPE-308] optionally ask for properties with default values in #60

Conversation

kwin
Copy link
Member

@kwin kwin commented Oct 8, 2020

interactive mode

@gunnarmorling
Copy link

gunnarmorling commented Nov 28, 2021

Hey @hboutemy, pinging you as I saw you recently committed to this repo. I am interested in seeing a solution to this issue here, so I'm wondering what is missing in order to resolve it? I'd be willing to help if there's need for it.

In terms of a solution, I think what's proposed here is good, only that'd I'd preferably make the new behavior the default (i.e. prompt for default options unless it's disabled explicitly). Alternatively, whether to prompt or not prompt could be a part of the archetype definition. WDYT?

// CC @rfscholte

@slachiewicz
Copy link
Member

could you rebase PR - we have conflict here: 137461e

@kwin kwin force-pushed the feature/ARCHETYPE-308-flag-for-default-property-behaviour branch from 823dba0 to 49f3454 Compare December 14, 2021 08:32
@kwin
Copy link
Member Author

kwin commented Dec 14, 2021

@slachiewicz I now rebased my PR.

slachiewicz pushed a commit that referenced this pull request Dec 14, 2021
@slachiewicz slachiewicz merged commit 9dc6960 into apache:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants