[ARCHETYPE-622] - maven-archetype-plugin integration-test doesn't use… #86
Conversation
|
@hboutemy @rfscholte @olamy Can any of you have a look at this PR? Thanks! |
MarianMacik
force-pushed
the
ARCHETYPE-622
branch
2 times, most recently
from
eb2be0c
to
967bb27
Compare
|
@hboutemy @rfscholte @olamy Can anyone from you approve rerunning the workflow? I added some debug information to understand why tests work locally but don't on GitHub. Thanks! |
|
@slachiewicz I noticed you approved running it last time, can you retrigger it, please? |
MarianMacik
force-pushed
the
ARCHETYPE-622
branch
3 times, most recently
from
111336a
to
82459ac
Compare
… Maven settings from the main build
MarianMacik
force-pushed
the
ARCHETYPE-622
branch
from
82459ac
to
6eaf182
Compare
|
Test failure is resolved now. I was counting on the fact that everything will be downloaded from the local repository but turned out some artifacts still need to be downloaded. I came up with an even better check to actually check Maven debug output for the correct settings file. Can anybody retrigger the PR check, please? Thanks! |
|
@slachiewicz Sorry to bother you again, but 3 combinations failed because of unrelated issues. Can you retrigger? It must be some infrastructure issue. |
|
@slachiewicz Thanks! It's green now! Can you merge it or should I write somewhere to the mailing list? |
|
Let me review it here |
|
@slachiewicz Thanks! |
… Maven settings from the main build
ARCHETYPE-622
Hi @hboutemy,
can you please look at the PR? I think it may be good to unify the behaviour of maven-archetype-plugin:integration-test with the invoker in terms of settings.xml consumption. Otherwise when one tries to make it behave the same, unnecessary workarounds are needed. I have also included a test which tests that the correct settings were passed to the archetype by checking the download output of the build.
Thanks!