Renamed local variable in maven archetype quickstart #26
Conversation
| @@ -1,11 +1,11 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| #macro( compilerProperties $javaCompilerVersion ) | |||
| #macro( compilerProperties $javaCompilerVersionLocal ) | |||
There was a problem hiding this comment.
Is this variable set by user code/properties somewhere that will need to update to the new name?
There was a problem hiding this comment.
no. TL/DR, yes and no,which was the reasoning of the PR. javaCompilerVersion is a property which can (and should) be used to set desired bytecode version, however in maven-archetype-quickstart it is partially broken (https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-77) .
In the line of question, however it is not the variable, but it's macro-local copy. See the calls:
and
When I was trying to fix the https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-77, this local occurrence was still meddling in.
Note, that this PR suggest two names. I prefer the one ion first commit, but the second is probably better. I'm ok with any name you would be happy with. TY!
compilerProperties had one parameter - javaCompilerVersion. This commit is renaming this parameter and its usage to jcv, so it is no longer exchangable for the property
judovana
force-pushed
the
renamedLocalVariableIn-maven-archetype-quickstart
branch
from
bb92797
to
a1e637a
Compare
|
rebased to master at a0f0e9a , to see ti against all jdk8-21 tests. |
|
tyvm sir! |
There is macro which is using parameter and its local occurrence of same name as is global property, thus shadowing it. This PR is renaming it so it is unique or at least distinguishable (second commit)
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.