Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MSHARED-922] remove checksum calculation from ProjectDeployer #16

Closed
wants to merge 1 commit into from

Conversation

kwin
Copy link
Member

@kwin kwin commented Jun 11, 2020

The checksums are generated in aether/maven-resolver

The checksums are generated in aether/maven-resolver
@elharo elharo changed the title MSHARED-922 remove checksum calculation from ProjectDeployer [MSHARED-922] remove checksum calculation from ProjectDeployer Jun 11, 2020
@michael-o
Copy link
Member

I wonder whether this could affect older Maven versions which update to a plugin with this shared component version.

@kwin
Copy link
Member Author

kwin commented Jun 11, 2020

The relevant IT is executed with Maven 3.0.5 and newer (

) and explicitly tests for checksums. This IT still works even after removing checksum generation from this module (because both Aether for Maven < 3.1 and Maven Resolver for 3.1+ generate the necessary checksums)

@michael-o
Copy link
Member

Makes sense. I'll run all tests on Jenkins. @rfscholte @khmarbaise opinions?

@rfscholte
Copy link
Contributor

It confirms my expectations: checksums are indeed generated by Aether/Artifact Resolver and not anymore required in the plugins or artifact-transfer.

@michael-o
Copy link
Member

So we are good to merge here...?

asfgit pushed a commit that referenced this pull request Jun 11, 2020
The checksums are generated by Maven Resolver

This closes #16
@asfgit asfgit closed this in a8fd9dc Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants