[MASSEMBLY-1008] Fix transitive dependencies resolving with required scope #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This IT demonstrates how assembly plugin (among others) does wrongly, the code probably originates from Maven2 times. What happens: * "single" mojo resolves test project dependencies * then it reads assembly descriptor * then uses project dependencies to deliver descriptor contents But, here is a problem that IT demonstrates: the delivered list of files are NOT runtime scoped, they are "test scope filtered for runtime leaves" which is not the same thing. By the way, dependency plugin demonstrates same behaviour, wrongly assumes that "test" graph is larger "runtime" tree, but that is not true nor was never true since Maven3 (resolver), it was true ONLY in Maven2 times.
slawekjaranowski
force-pushed
the
massembly-1008
branch
from
23442c0
to
34e9938
Compare
slawekjaranowski
changed the title
|
@cstamas please look - build pass |
|
@cstamas - kindly reminder |
gnodet
requested changes
Jan 8, 2024
src/main/java/org/apache/maven/plugins/assembly/artifact/DefaultDependencyResolver.java
Outdated
Show resolved
Hide resolved
|
LGTM (cannot approve as I opened this PR 😄 ) |
|
🎆 |
|
Thanks @slawekjaranowski , jotted down several 🍻 for you once we meet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This IT demonstrates how assembly plugin (among others) does it wrongly, as the plugin code probably originates from Maven2 times.
What happens:
But, here is a problem that IT demonstrates: the delivered list of files are NOT runtime scoped, they are "test scope filtered for runtime leaves" which is not the same thing. By the way, dependency plugin demonstrates same behavior: wrongly assumes that "test" graph is super set of "runtime" tree, but that is not true nor was never true since Maven3 (resolver), it was true ONLY in Maven2 times.
The proper runtime graph of IT project as shown by resolver is this: