Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MASSEMBLY-1008] Fix transitive dependencies resolving with required scope #166

Merged
merged 5 commits into from
Jan 30, 2024

Commits on Dec 25, 2023

  1. [MASSEMBLY-1008] Wrong use of dependency scopes

    This IT demonstrates how assembly plugin (among others)
    does wrongly, the code probably originates from Maven2
    times.
    
    What happens:
    * "single" mojo resolves test project dependencies
    * then it reads assembly descriptor
    * then uses project dependencies to deliver descriptor contents
    
    But, here is a problem that IT demonstrates: the delivered list
    of files are NOT runtime scoped, they are "test scope filtered
    for runtime leaves" which is not the same thing. By the way,
    dependency plugin demonstrates same behaviour, wrongly assumes
    that "test" graph is larger "runtime" tree, but that is not true
    nor was never true since Maven3 (resolver), it was true ONLY in
    Maven2 times.
    cstamas authored and slawekjaranowski committed Dec 25, 2023
    Configuration menu
    Copy the full SHA
    0de3fcc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    16def83 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Configuration menu
    Copy the full SHA
    34e9938 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c6475b4 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Configuration menu
    Copy the full SHA
    1df4a79 View commit details
    Browse the repository at this point in the history