Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDEP-712] update JIRA URL #17

Merged
merged 4 commits into from
Jul 22, 2020
Merged

[MDEP-712] update JIRA URL #17

merged 4 commits into from
Jul 22, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 11, 2020

@elharo elharo requested a review from slachiewicz July 11, 2020 15:07
@elharo elharo changed the title update JIRA URL [MDEP-712] update JIRA URL Jul 12, 2020
pom.xml Outdated
@@ -45,7 +45,7 @@
</scm>
<issueManagement>
<system>jira</system>
<url>https://issues.apache.org/jira/browse/MSHARED/component/12326428</url>
<url>https://issues.apache.org/jira/browse/MSHARED-932?jql=project%20%3D%20MSHARED%20AND%20component%20%3D%20maven-dependency-analyzer</url>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it point to JIRA without reference to specific issue, like MSHARED-932 here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, this needs to be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What URL do you suggest? So far I have not been able to construct one that works and does not include an issue.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What URL do you suggest? So far I have not been able to construct one that works and does not include an issue.

Similar to one proposed in apache/maven-project-utils#3 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@elharo elharo merged commit 5a9ea0f into master Jul 22, 2020
@elharo elharo deleted the elharo-patch-1 branch July 22, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants