[MDEP-894] Use @Component only - fix tests
#360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests still fail for me .... |
Yes, that's the point. A misconfig or dep is missing. |
|
@michael-o @cstamas please look at my commit ... I fix one test by adding mock MavenProject and MavenSession as component in test |
|
Unit test pass. Site build due to parameters list can be null 😄 |
|
@slawekjaranowski This is fantastic work, thank you. Your change must go with the upgrade of MPLUGIN with every modified plugin as well as this one. |
slawekjaranowski
force-pushed
the
MPLUGIN-495
branch
from
5b114b7
to
4e181ee
Compare
|
rebased and use latest released versions of m-plugin-tools |
slawekjaranowski
approved these changes
Mar 22, 2024
slawekjaranowski
changed the title
@Component only@Component only - fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should depict the failing behavior.