[MPLUGIN-495] WARNINGs based on usage of @Component for MavenSession/MavenProject instead of @Parameter #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested review from
khmarbaise,
cstamas,
gnodet,
hboutemy and
slawekjaranowski
|
We also have the same in |
slawekjaranowski
requested changes
Dec 28, 2023
.../apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java
Outdated
Show resolved
Hide resolved
Working on it. At some point (4.0.0) we should consider dropping support for Javadoc style, only annotation style should remain. |
asfgit
pushed a commit
that referenced
this pull request
Dec 28, 2023
…MavenProject instead of @parameter This closes #253
|
I jave just tried a snapshot against Maven Dependency Plugin as @khmarbaise has reported. I get: I guess something is missing on the test classpath, but I have no idea what... |
asfgit
pushed a commit
that referenced
this pull request
Dec 28, 2023
…MavenProject instead of @parameter This closes #253
|
@cstamas Any ideas? |
|
OutOfScopeException of MavenSession. You used Maven 4.0.0-alpha-10? |
No, 3.8.8. |
|
Hm, with 3.9.6 it "works for me" |
Did you build a snapshot of this and apply it to Maven Dependency Plugin? |
|
hm, nope, i assumed this PR fails to build.... |
It works, but not the subsequent use in tests. ITs do work, actually. So I guessed that some dep is missing during tests. |
Or unit test simply try to lookup Mojo without calling |
|
We can remove |
|
Parameter list can be null ... we also need a fix like: --- a/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
+++ b/maven-plugin-report-plugin/src/main/java/org/apache/maven/plugins/plugin/descriptor/EnhancedPluginDescriptorBuilder.java
@@ -21,9 +21,11 @@ package org.apache.maven.plugins.plugin.descriptor;
import java.io.Reader;
import java.net.URI;
import java.util.ArrayList;
+import java.util.Collections;
import java.util.LinkedHashMap;
import java.util.List;
import java.util.Map;
+import java.util.Optional;
import org.apache.maven.plugin.descriptor.MojoDescriptor;
import org.apache.maven.plugin.descriptor.Parameter;
@@ -87,7 +89,8 @@ public class EnhancedPluginDescriptorBuilder extends PluginDescriptorBuilder {
PlexusConfiguration[] parameterConfigurations = c.getChild("parameters").getChildren("parameter");
- List<Parameter> parameters = new ArrayList<>(mojoDescriptor.getParameters());
+ List<Parameter> parameters = new ArrayList<>(
+ Optional.ofNullable(mojoDescriptor.getParameters()).orElseGet(Collections::emptyList));
Map<String, Parameter> parameterMap = new LinkedHashMap<>(mojoDescriptor.getParameterMap());
for (PlexusConfiguration d : parameterConfigurations) {
@@ -108,7 +111,9 @@ public class EnhancedPluginDescriptorBuilder extends PluginDescriptorBuilder {
}
// clear() is required for maven < 3.6.2
- mojoDescriptor.getParameters().clear();
+ if (mojoDescriptor.getParameters() != null) {
+ mojoDescriptor.getParameters().clear();
+ }
|
Thanks, working on this. I consider |
asfgit
pushed a commit
that referenced
this pull request
Dec 29, 2023
…MavenProject instead of @parameter This closes #253
slawekjaranowski
approved these changes
Dec 29, 2023
asfgit
pushed a commit
that referenced
this pull request
Dec 30, 2023
…MavenProject instead of @parameter This closes #253
asfgit
pushed a commit
that referenced
this pull request
Dec 30, 2023
…MavenProject instead of @parameter This closes #253
|
I have changed the comment regarding 3.6.2 because that statement is wrong. |
|
If I don't hear any objections the next couple of days I will merge this PR and the one with the docs update. @slawekjaranowski's fix on MDEP can be applied to all affected plugins moving to MPLUGIN 3.11.0. |
slawekjaranowski
approved these changes
Jan 1, 2024
9 tasks
asfgit
pushed a commit
that referenced
this pull request
Jan 6, 2024
…MavenProject instead of @parameter This closes #253
…MavenProject instead of @parameter This closes #253
|
Sorry for the late intervention. I'm not completely sure about discouraging the use of ${project.xxx} expressions. |
Both will continue to work, but if that is your concern can you file an issue regarding this, so it is not forgotten? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #253