[DOXIATOOLS-80] Update to Doxia 2.0.0-M6 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwin
force-pushed
the
feature/doxia-2
branch
from
3c549f4
to
43c84f5
Compare
|
@michael-o Any idea why one XHTML5 test fails with a parsing exception in Doxia 2? |
michael-o
requested changes
Feb 26, 2023
| <groupId>ch.qos.logback</groupId> | ||
| <artifactId>logback-classic</artifactId> | ||
| <version>1.2.11</version> | ||
| </dependency> |
There was a problem hiding this comment.
Why not SLF4J simple with runtime scope?
| + "' with the encoding '" + output.getEncoding() + "'"); | ||
| } | ||
| LOGGER.debug( | ||
| "Parsing file from '{}' with the encoding '{}'" + " to '{}' with the encoding '{}'", |
There was a problem hiding this comment.
Why not make it one string now?
| if (debug) { | ||
| log.setLogLevel(Log.LEVEL_DEBUG); | ||
| // TODO: programmatically adjust log level | ||
| } |
There was a problem hiding this comment.
Why then not drop the empty if clause?
I guess it misses the |
|
The generated XHTML is valid (look at the generated file) still the parser stumbles. |
only use index in sisu.plexus
slachiewicz
approved these changes
Mar 22, 2023
kwin
changed the title
michael-o
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.