Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some warnings #14

Merged
merged 4 commits into from
Feb 19, 2020
Merged

fix some warnings #14

merged 4 commits into from
Feb 19, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Feb 19, 2020

michael-o
michael-o requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting issues

...site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Outdated Show resolved Hide resolved
doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/AbstractVerifier.java Outdated Show resolved Hide resolved
...site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Outdated Show resolved Hide resolved
doxia-site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/JavascriptVerifier.java Outdated Show resolved Hide resolved
michael-o
michael-o requested changes Feb 19, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more nit.

...site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Outdated Show resolved Hide resolved
michael-o
michael-o requested changes Feb 19, 2020
View reviewed changes
...site-renderer/src/test/java/org/apache/maven/doxia/siterenderer/DefaultSiteRendererTest.java Outdated
@@ -297,7 +297,7 @@ public void testVelocityToolManagerForSkin()
String expectedResult = StringUtils.unifyLineSeparators(
IOUtils.toString(
getClass().getResourceAsStream( "velocity-toolmanager.expected.txt" ),
StandardCharsets.UTF_8));
StandardCharsets.UTF_8 ));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and another one between the parens.

michael-o
michael-o approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash and merge.

@elharo elharo merged commit ac64c42 into master Feb 19, 2020
@elharo elharo deleted the warn3 branch February 19, 2020 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@elharo @michael-o