Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINDEXER-115] Migrate to BooleanQuery.Builder #36

Merged
merged 1 commit into from May 9, 2019

Conversation

slachiewicz
Copy link
Member

Remove deprecated usages of BooleanQuery constructor - use Builder

Based on Sopot Cela changes

@slachiewicz slachiewicz mentioned this pull request Apr 11, 2019
@slachiewicz
Copy link
Member Author

@carlspring @fuss86 could You check if this patch is ok and would not introduce any regression?

@fuss86
Copy link
Contributor

fuss86 commented May 8, 2019

Hi @slachiewicz !

Have you tried building your branch ?

It seems you've got at least 2 checkstyle violations.

[INFO] --- maven-checkstyle-plugin:2.17:check (checkstyle-check) @ indexer-examples-basic ---
[INFO] There are 3 errors reported by Checkstyle 6.11.2 with config/maven_checks.xml ruleset.
[ERROR] src\main\java\org\apache\maven\indexer\examples\BasicUsageExample.java:[244] (sizes) LineLength: Line is longer than 120 characters (found 128).
[ERROR] src\main\java\org\apache\maven\indexer\examples\BasicUsageExample.java:[317] (sizes) LineLength: Line is longer than 120 characters (found 131).
[INFO] Ignored 1 error, 2 violations remaining.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Maven-Indexer ...................................... SUCCESS [ 23.165 s]
[INFO] Maven :: Indexer Core .............................. SUCCESS [ 49.780 s]
[INFO] Maven :: Indexer CLI ............................... SUCCESS [  7.111 s]
[INFO] Maven :: Indexer Reader ............................ SUCCESS [  6.901 s]
[INFO] Maven :: Indexer Examples .......................... SUCCESS [  0.746 s]
[INFO] Maven :: Indexer Examples [Basic] .................. FAILURE [  3.363 s]
[INFO] Maven :: Indexer Examples [Spring] ................. SKIPPED

@fuss86
Copy link
Contributor

fuss86 commented May 8, 2019

@slachiewicz, I cherry-picked your commit into our fork and all unit and integrations tests have passed. No regression on our side spotted.

Hope it helps :)

Remove deprecated usages of BooleanQuery constructor - use Builder

Based on Sopot Cela changes
@asfgit asfgit merged commit 92cca9c into apache:master May 9, 2019
@slachiewicz slachiewicz deleted the MINDEXER-115 branch May 9, 2019 09:07
@slachiewicz
Copy link
Member Author

Thx @fuss86 for testing. I fixed checkstyle issuess and code now is on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants