New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getName() to Record.EntryKey #39
Conversation
Can you please open a JIRA and change the commit message? |
Are you saying I should remove "I don't want to parse the output from toString()" or add more detail to the commit message? "I don't want to parse the output from toString()" is only added to the pull request. I didn't put it in the commit message. I made this: https://issues.apache.org/jira/browse/MINDEXER-122 Do all public API changes have to have a JIRA ticket? |
I went ahead and added some stuff to the commit message. |
Thanks. The only missing part is to cite the ticket at the beginning of the message. I can do it We use JIRA to organize the release notes and keep track of want is delivered on each version. |
Ok. Commit messages have the JIRA ticket name in them and the JIRA tickets have a link to the pull requests. The only thing I didn't do is name my branches to be equal to the name of the JIRA ticket. That would require recreating the pull request. : \ I could do that though if you want. |
No need to rename the branch. |
CI is okay I will merge tomorrow |
Thx merged with 09d3582 |
Should I close this? |
Yes, please |
I don't want to parse the output from toString()