Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getName() to Record.EntryKey #39

Closed
wants to merge 1 commit into from
Closed

Add getName() to Record.EntryKey #39

wants to merge 1 commit into from

Conversation

sixcorners
Copy link
Contributor

I don't want to parse the output from toString()

@eolivelli
Copy link

eolivelli commented Aug 17, 2019

Can you please open a JIRA and change the commit message?
I will be happy to merge, the change is trivial an useful, but it is a public API change

@sixcorners
Copy link
Contributor Author

sixcorners commented Aug 18, 2019

Are you saying I should remove "I don't want to parse the output from toString()" or add more detail to the commit message? "I don't want to parse the output from toString()" is only added to the pull request. I didn't put it in the commit message.

I made this: https://issues.apache.org/jira/browse/MINDEXER-122 Do all public API changes have to have a JIRA ticket?

@sixcorners
Copy link
Contributor Author

I went ahead and added some stuff to the commit message.

@eolivelli
Copy link

Thanks.
I forgot to link the guide for you
https://maven.apache.org/developers/conventions/git.html

The only missing part is to cite the ticket at the beginning of the message. I can do it

We use JIRA to organize the release notes and keep track of want is delivered on each version.
Maven project is made of about 100 subprojects and we need some paperwork in order not to forget or to follow the wrong way

@sixcorners
Copy link
Contributor Author

Ok. Commit messages have the JIRA ticket name in them and the JIRA tickets have a link to the pull requests. The only thing I didn't do is name my branches to be equal to the name of the JIRA ticket. That would require recreating the pull request. : \ I could do that though if you want.
Thanks for walking me helping me learn the process.

@eolivelli
Copy link

No need to rename the branch.

@eolivelli
Copy link

@eolivelli
Copy link

CI is okay I will merge tomorrow

@slachiewicz
Copy link
Member

Thx merged with 09d3582

@sixcorners
Copy link
Contributor Author

Should I close this?

@slachiewicz
Copy link
Member

Yes, please

@sixcorners sixcorners closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants